Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InstaScale Configmap name #85

Closed
anishasthana opened this issue Apr 3, 2023 · 2 comments
Closed

Change InstaScale Configmap name #85

anishasthana opened this issue Apr 3, 2023 · 2 comments
Assignees
@anishasthana

Comments

@anishasthana
Copy link
Member

Relevant InstaScale PR: project-codeflare/instascale#52

InstaScale always expects a configmap with the name instascale-config to exist in a namespace. Our current configmap name does not align with that -- we should fix it.
@anishasthana
Copy link
Member Author

As part of this we will also need to update the deployment template to pass in the configmap namespace.

@anishasthana anishasthana self-assigned this Apr 11, 2023
@astefanutti
Copy link
Contributor

This has become obsolete with #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anishasthana anishasthana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astefanutti @anishasthana