Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of pods of created AppWrapper not logged correctly #646

Open
ChristianZaccaria opened this issue Sep 22, 2023 · 3 comments
Open

Number of pods of created AppWrapper not logged correctly #646

ChristianZaccaria opened this issue Sep 22, 2023 · 3 comments

Comments

@ChristianZaccaria
Copy link
Contributor

ChristianZaccaria commented Sep 22, 2023

Describe the Bug

After creating an AppWrapper, the logs display that there are 0 pods while there are actually 3 pods running.

The reason for this is that the pods created have the label i.e., ray.io/cluster when they should have appwrapper.mcad.ibm.com. As discussed in this PR, it seems the controller owning the resource / generic item is overwriting the label applied by MCAD.

Steps to Reproduce the Bug

  1. With MCAD running
  2. Create an AppWrapper
  3. Search in the MCAD logs for There are.
  4. See 0 pods of your AppWrapper, when there should be 3.
    image

AND

  1. With MCAD running
  2. Create an AppWrapper
  3. Check the pods' labels

Expected Behavior

When an AppWrapper is created, the logs should display the correct number of pods for the AppWrapper.

Component Versions

Kuberay: v0.5.0
MCAD: latest main branch

@jbusche
Copy link
Contributor

jbusche commented Nov 13, 2023

@Bobbins228, is it possible that your MCAD logging PR 678 addresses this issue? cc: @dimakis

@Bobbins228
Copy link

@jbusche It does not but the PR is still up so I can add this in along side it

@jbusche
Copy link
Contributor

jbusche commented Nov 13, 2023

Thank you!

@Bobbins228 Bobbins228 self-assigned this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants