-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of pods of created AppWrapper not logged correctly #646
Comments
3 tasks
ChristianZaccaria
moved this from In Progress
to In Review
in Project CodeFlare Sprint Board
Sep 22, 2023
ChristianZaccaria
moved this from In Review
to Ready For Review
in Project CodeFlare Sprint Board
Sep 22, 2023
ChristianZaccaria
moved this from Ready For Review
to Todo
in Project CodeFlare Sprint Board
Sep 25, 2023
@Bobbins228, is it possible that your MCAD logging PR 678 addresses this issue? cc: @dimakis |
@jbusche It does not but the PR is still up so I can add this in along side it |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
After creating an AppWrapper, the logs display that there are 0 pods while there are actually 3 pods running.
The reason for this is that the pods created have the label i.e.,
ray.io/cluster
when they should haveappwrapper.mcad.ibm.com
. As discussed in this PR, it seems the controller owning the resource / generic item is overwriting the label applied by MCAD.Steps to Reproduce the Bug
There are
.AND
Expected Behavior
When an AppWrapper is created, the logs should display the correct number of pods for the AppWrapper.
Component Versions
Kuberay: v0.5.0
MCAD: latest main branch
The text was updated successfully, but these errors were encountered: