Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the helm deployer #664

Open
kpouget opened this issue Oct 18, 2023 · 0 comments
Open

Improve the helm deployer #664

kpouget opened this issue Oct 18, 2023 · 0 comments

Comments

@kpouget
Copy link

kpouget commented Oct 18, 2023

Name of Feature or Improvement

Get the helm deployer in a decent state to ease the deployment of the main branch

Description of Problem the Feature Should Solve

  • namespace cannot be configured, it's hardcoded to kube-system
  • mcad deployment labels are inconsistent (app: custom-metrics-apiserver)
  • mcad deployment name is different from ODH (minor, but better for consistency)
  • mcad default image mcad-controller:latest does not work [in OpenShift at least], ErrImagePull
  • the AppWrapper CRD is not deployed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpouget