-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove magic numbers in Cubescript UIs #1
Comments
Hi, could you assign this issue to me please? |
Great, you've been assigned. You'll likely need to tabulate all magic numbers and then figure out what semantics they should have (e.g. button width, height, etc.), before being able to create constant aliases for them. Additionally, some work setting defaults for elements which are almost always given a particular number might be worth doing (though not necessarily in the scope of this particular issue). |
The current UI system utilizes many magic constants in its padding and object sizes which should be standardized to modifiable constants. Using proper constants for this behavior should make it possible to clearly standardize UI forms and make uniform UX design simpler.
The text was updated successfully, but these errors were encountered: