Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic numbers in Cubescript UIs #1

Open
no-lex opened this issue Jun 28, 2020 · 2 comments
Open

Remove magic numbers in Cubescript UIs #1

no-lex opened this issue Jun 28, 2020 · 2 comments
Assignees

Comments

@no-lex
Copy link
Member

no-lex commented Jun 28, 2020

The current UI system utilizes many magic constants in its padding and object sizes which should be standardized to modifiable constants. Using proper constants for this behavior should make it possible to clearly standardize UI forms and make uniform UX design simpler.

@b-sharman
Copy link
Member

Hi, could you assign this issue to me please?

@no-lex
Copy link
Member Author

no-lex commented Jul 10, 2020

Great, you've been assigned.

You'll likely need to tabulate all magic numbers and then figure out what semantics they should have (e.g. button width, height, etc.), before being able to create constant aliases for them.

Additionally, some work setting defaults for elements which are almost always given a particular number might be worth doing (though not necessarily in the scope of this particular issue).

@no-lex no-lex transferred this issue from project-imprimis/libprimis Nov 30, 2020
b-sharman added a commit to b-sharman/imprimis that referenced this issue Dec 30, 2020
no-lex added a commit that referenced this issue Jan 4, 2021
cleans up scoreboard.cfg for #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants