Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory traversal is depth-first instead of breadth-first #44

Open
ariel-miculas opened this issue Nov 1, 2022 · 0 comments
Open

Comments

@ariel-miculas
Copy link
Collaborator

walker in builder/src/lib.rs says:

breadth first search for sharing, don't cross filesystems just to be safe, order by file name.

It's also mentioned in doc/chunking.md:

We serialize the filesystem by doing a breadth first walk, ordering directory
entries lexicographically. We use a breadth first search so that hopefully
package directories can be shared.

but https://docs.rs/walkdir/latest/walkdir/struct.WalkDir.html traverses the directory in depth-first fashion.

Furthermore, it doesn't provide support for breadth-first search:
BurntSushi/walkdir#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant