From 4b1b354d8b02faac2e11c1e88229c488ea9b7693 Mon Sep 17 00:00:00 2001
From: Demolemon11 <demolemon@outlook.at>
Date: Fri, 15 Nov 2024 10:35:41 +0800
Subject: [PATCH] Fix send permission

---
 src/home/room_screen.rs | 56 ++++++++++++++++++++---------------------
 src/sliding_sync.rs     | 22 ++++++++++------
 2 files changed, 42 insertions(+), 36 deletions(-)

diff --git a/src/home/room_screen.rs b/src/home/room_screen.rs
index 23b0aeeb..c15c3736 100644
--- a/src/home/room_screen.rs
+++ b/src/home/room_screen.rs
@@ -613,30 +613,7 @@ live_design! {
 
         // A jump to bottom button (with an unread message badge) that is shown
         // when the timeline is not at the bottom.
-        <View> {
-            flow: Down
-
-            jump_to_bottom = <JumpToBottomButton> { }
-
-            no_send_permisson_notice = <View> {
-                visible: false
-                show_bg: true
-                draw_bg: {
-                    color: #xFF000030
-                }
-                padding: {left: 90}
-                align: {y: 0.5}
-                width: Fill, height: 28,
-
-                <Label> {
-                    draw_text: {
-                        color: #111111
-                        text_style: <THEME_FONT_ITALIC>{font_size: 13.5}
-                    }
-                    text: "You have no permission to send messages in this room"
-                }
-            }
-        }
+        jump_to_bottom = <JumpToBottomButton> { }
     }
 
     LocationPreview = {{LocationPreview}} {
@@ -932,6 +909,24 @@ live_design! {
                         icon_walk: {width: 18.0, height: Fit},
                     }
                 }
+                no_send_permisson_notice = <View> {
+                    visible: false
+                    show_bg: true
+                    draw_bg: {
+                        color: #EFEFEF
+                    }
+                    padding: {left: 75}
+                    align: {y: 0.5}
+                    width: Fill, height: 31,
+
+                    <Label> {
+                        draw_text: {
+                            color: #111111
+                            text_style: <THEME_FONT_ITALIC>{font_size: 12.2}
+                        }
+                        text: "You don't have permission to post to this room"
+                    }
+                }
             }
 
             // The top space should be displayed on top of the timeline
@@ -1173,8 +1168,7 @@ impl Widget for RoomScreen {
                     }
                 }
             }
-            // Check if the user has permission to send message in this room.
-            self.check_self_has_send_permission();
+
             // Set visibility of loading message banner based of pagination logic
             self.send_pagination_request_based_on_scroll_pos(cx, actions, &portal_list);
             // Handle sending any read receipts for the current logged-in user.
@@ -1590,6 +1584,10 @@ impl RoomScreen {
                         bottom_input.set_visible(false);
                         no_send_permisson_notice.set_visible(true)
                     }
+                    else {
+                        bottom_input.set_visible(true);
+                        no_send_permisson_notice.set_visible(false)
+                    }
                 }
 
             }
@@ -1764,6 +1762,8 @@ impl RoomScreen {
             submit_async_request(MatrixRequest::FetchRoomMembers { room_id });
         }
 
+        // Check if the user has permission to send message in this room.
+        self.check_user_permission();
         // Now, restore the visual state of this timeline from its previously-saved state.
         self.restore_state(cx, &mut tl_state);
 
@@ -1963,9 +1963,9 @@ impl RoomScreen {
         }
         tl.last_scrolled_index = first_index;
     }
-    fn check_self_has_send_permission(&self) {
+    fn check_user_permission(&self) {
         if let Some(room_id) = self.room_id.clone() {
-            submit_async_request(MatrixRequest::CheckIfSelfCanSendMessage { room_id })
+            submit_async_request(MatrixRequest::CheckUserSendPermission { room_id })
         }
     }
 }
diff --git a/src/sliding_sync.rs b/src/sliding_sync.rs
index 60ac75f3..b58f67df 100644
--- a/src/sliding_sync.rs
+++ b/src/sliding_sync.rs
@@ -288,7 +288,7 @@ pub enum MatrixRequest {
         room_id: OwnedRoomId,
         event_id: OwnedEventId,
     },
-    CheckIfSelfCanSendMessage{
+    CheckUserSendPermission{
         room_id: OwnedRoomId,
     }
 }
@@ -700,22 +700,28 @@ async fn async_worker(
                 });
             }
 
-            MatrixRequest::CheckIfSelfCanSendMessage { room_id } => {
-                let sender = {
+            MatrixRequest::CheckUserSendPermission { room_id } => {
+                let (timeline, sender) = {
                     let all_room_info = ALL_ROOM_INFO.lock().unwrap();
                     let Some(room_info) = all_room_info.get(&room_id) else {
                         log!("BUG: room info not found for fetch members request {room_id}");
                         continue;
                     };
 
-                    room_info.timeline_update_sender.clone()
+                    (room_info.timeline.clone(), room_info.timeline_update_sender.clone())
                 };
 
                 let Some(client) = CLIENT.get() else { continue };
-                let user_id = client.user_id().unwrap();
-                let room = client.get_room(&room_id).unwrap();
-                let can_send = room.can_user_send_message(user_id, matrix_sdk::ruma::events::MessageLikeEventType::Message).await.unwrap_or(true);
-                sender.send(TimelineUpdate::SendPermission(can_send)).unwrap();
+                let Some(user_id) = client.user_id() else { continue };
+
+                let _send_frr_task = Handle::current().spawn(async move {
+                    let room = timeline.room();
+                    let can_send = room.can_user_send_message(user_id, matrix_sdk::ruma::events::MessageLikeEventType::Message).await.unwrap_or(false);
+
+                    if let Err(_) = sender.send(TimelineUpdate::SendPermission(can_send)) {
+                        error!("Failed to send the result of user send permission")
+                    }
+                });
             }
         }
     }