Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display reactions as emojis #111

Open
kevinaboos opened this issue Aug 19, 2024 · 0 comments
Open

Display reactions as emojis #111

kevinaboos opened this issue Aug 19, 2024 · 0 comments
Labels
blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature good first issue Good for newcomers help wanted Looking for help from anyone!

Comments

@kevinaboos
Copy link
Member

kevinaboos commented Aug 19, 2024

Currently, reactions are represented as regular strings in an italicized font. This is realized by using the emojis crate to convert an emoji to a string representation, e.g., 🫠 is transformed into its plaintext representation: :melting_face:.

However, this issue is currently blocked, because Makepad doesn't yet support rendering emoji, though this is actively in progress. Once Makepad supports emoji, we can easily make this change to remove the "plaintext-ification" of emojis, and instead just have Makepad render the reaction string as normal

Note that we should keep the design of emojis being represented by the String type, since reactions in Matrix can also just be any arbitrary string of text.

@kevinaboos kevinaboos added good first issue Good for newcomers help wanted Looking for help from anyone! labels Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Ready in Robrix Aug 19, 2024
@kevinaboos kevinaboos moved this from Ready to Blocked in Robrix Aug 19, 2024
@kevinaboos kevinaboos added the blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature good first issue Good for newcomers help wanted Looking for help from anyone!
Projects
Status: Blocked
Development

No branches or pull requests

1 participant