Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that a previous SSO login session can be restored #265

Closed
kevinaboos opened this issue Nov 21, 2024 · 1 comment
Closed

Ensure that a previous SSO login session can be restored #265

kevinaboos opened this issue Nov 21, 2024 · 1 comment
Assignees
@kevinaboos @alanpoon

Comments

@kevinaboos
Copy link
Member

We have tested this thoroughly with username+password logins and it works fine. Now that #217 has landed, which adds support for SSO-based login, we need to test that as well.

We also may need to change the way that most_recent_user_id() works, since it stores a fully-qualified user ID with a homeserver address in it (e.g., [email protected]), and I'm not sure if SSO-based logins also have that kind of username available.
@kevinaboos
Copy link
Member Author

Tested to work with both Google and Github logins. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinaboos kevinaboos

@alanpoon alanpoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinaboos @alanpoon