Stable positioning of timeline items across background updates #45
+144
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king. However, it could be more efficient by having the background timeline subscriber task include some information about where the changes were made, which would allow us to avoid searching the entire timeline list for the ID of the event that was previously shown at the top. Also added some infra for avoiding redundant drawing work based on whether a timeline item has been changed in the background, but that is not yet being used.
|
There are still some log statements in there for debugging, so this isn't quite ready yet. |
…nts. Had to manually implement the `VectorDiff::apply()` function so we could interpose on what diffs were being applied and where.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be working well.
However, it could be more efficient by having the background timeline subscriber task include some information about where the changes were made, which would allow us to avoid searching the entire timeline list for the ID of the event that was previously shown at the top.
Also added some infra for avoiding redundant drawing work based on whether a timeline item has been changed in the background, but that is not yet being used.