New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to ditch the 'bn.js' dependency in favour of native JS BigInt? #251

Open

mikemaccana opened this issue Jul 17, 2023 · 0 comments

mikemaccana commented Jul 17, 2023 •

edited

Loading

Looks like https://github.com/project-serum/serum-ts/blob/master/packages/borsh/src/index.ts still uses 'bn'.js' - is there a technical reason we wouldn't ditch the 'bn.js' dependency in favour of native BigInt?

BigInt works in most places since 2019 / 2020. Removing 'bn.js' would remove an unnecessary dependency and reduce the surface area for security issues and vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment