Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connecting, no event is emitted on failure #44

Open
jordaaash opened this issue Sep 10, 2021 · 1 comment
Open

When connecting, no event is emitted on failure #44

jordaaash opened this issue Sep 10, 2021 · 1 comment

Comments

@jordaaash
Copy link

When using the web version, if the popup is blocked by the browser or closed by the user, the connect call will hang and never emit an event or reject its promise.

Similarly for the extension, if the user declines permission to connect or closes the extension popup, the connect call will never emit an event. It also resolves its promise immediately (#24).

Dapps can listen for a connect event but cannot reliably detect the connection failure and are left in an unknown state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@jordaaash and others