Fixed freezing issue when logging in from fullscreen #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain why the order matters? |
|
I don't know for sure, but best guess: The bug seems to airise from a compiler optimization, I cannot reproduce the bug when using the debug build. When changing the order the compiler doesn't do the problematic optimization and the bug dissapears. |
|
Tested this build on windows by following r2dliu's repro steps and it froze dolphin entirely, had to force kill in task manager. |
|
Ok then I'm unsure what to do. Sleeping the thread for a second after user->OpenLogInPage(); also solves the issue on my setup. New best guess is that the system command interacts poorly with something downstream but I have no good solutions in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved by opening the webpage before minimizing
Fixes #119