Quick Draw Damage

[topaz-bot]

Issue by RwNigma
Tuesday May 26, 2015 at 20:46 GMT
Originally opened as DarkstarProject/darkstar - Issue 1480

---

Darkstar Issue Darkstar Issue This is the current damage modifier:

local dmg = 2 * player:getRangedDmg() + player:getAmmoDmg() + player:getMod(MOD_QUICK_DRAW_DMG);

This doesn't check for Elemental Staffs, MAB, and Weather. MOD_QUICK_DRAW_DMG may account for these, but looking at that variable I don't see where these are applied.
Darkstar Issue Darkstar Issue Damage according to The wiki page is as follows:

(I understand the Tricone isn't coded)
(2 * (Gun base DMG + bullet base DMG + Corsair's Tricorne bonus)) * (1 + (MAB / 100)) * (Elemental Staff bonus) * (Day/Weather Bonus)
Darkstar Issue Darkstar Issue I also noticed that the shots are giving improper status effects. These apply to all of them giving these types of status effects.

Wind Shot:
local effects = {};
local counter = 1;
local choke = target:getStatusEffect(EFFECT_CHOKE);
if (choke ~= nil) then
effects[counter] = choke;
counter = counter + 1;
end
Going to assume this gives the mob "Choke"? This gives a VIT debuff and lowers total HP?
Darkstar Issue Darkstar Issue FFxiCyclo has Shots as listed:

Light Shot: Dia Defense Down+5%, Damage Over Time increase *
Dark Shot: Bio Attack Down+5%, Damage Over Time increase; Blind+10%
Earth Shot: Slow+10%
Wind Shot: Acid Bolt Defense Down+5%, Silence+10%, Gravity+10%
Ice Shot: Paralyze+10%, Bind+10%
Thunder Shot: Stun+10%
Water Shot: Poison Duration increase

Special Note about Dia/Bio: Quick Draw will upgrade Bio and Dia to their next spell tier. E.g. Dia II augmented by Light Shot becomes equivalent to Dia III and thus is not overwritten by Bio II. Presumably, Bio III and Dia III augmented by Quick Draw become equivalent to "Bio IV" and "Dia IV."Exclamation
Regardless of tier, the bonus provides a flat +3 DoT bonus.

[topaz-bot]

Comment by RwNigma
Tuesday May 26, 2015 at 20:54 GMT

---

I am interested in Coding and have C++, Visual Basic, and Java under my belt. I wouldn't mind giving it a go and coding when I get settled after this week. I have talked to Nesstea before about it and I just need to get the files and start on things.

[topaz-bot]

Comment by takhlaq
Tuesday May 26, 2015 at 21:09 GMT

---

hop on irc if you need anything (see github/DarkstarProject/darkstar/blob/master/README.md for info)

[topaz-bot]

Comment by teschnei
Tuesday May 26, 2015 at 22:08 GMT

---

"This doesn't check for Elemental Staffs, MAB, and Weather."

sure it does. it's actually on the very next line

[topaz-bot]

Comment by teschnei
Tuesday May 26, 2015 at 22:11 GMT

---

as for the chunk about choke, it doesn't actually do anything yet at that point, just checks if the mob has choke and saves the effect for later. (later it checks the array of effects the target has, picks one, and augments it. for this specific shot, it checks for choke and threnody)

[topaz-bot]

Comment by RwNigma
Wednesday May 27, 2015 at 02:08 GMT

---

I see the earth staff under the player bonuses. Is the weather then under "params" within playerbonuses? Magic attack bouns I don't see within the code unless again it is within "params". I know that getlines(); tend to grab from almost anywhere, and from classes and books that its the easy way to do things.

Checks if it has choke...Shouldn't it check if it has Slow? Or this is just to apply extra damage to it if it has choke applied? First time with LUA, but it looks a lot like C++. Just wanting to get better at it. And I am not meaning to post things if it doesn't need to be fixed, but more to make sure I guess.

[topaz-bot]

Comment by teschnei
Wednesday May 27, 2015 at 02:10 GMT

---

Slow is an earth spell, so wind shot would not check it (earth shot would, and does).

addBonusesAbility is in magic.lua, you can see everything for affinity (staff) and weather in there

[topaz-bot]

Comment by RwNigma
Wednesday May 27, 2015 at 02:12 GMT

---

Was looking in earth shot and was talking here still as I was looking at wind shot.

So does wind shot actually give the mob gravity status, DEF down, and Silence?

magic.lua makes my head hurt haha.

[topaz-bot]

Comment by dazusu
Wednesday May 27, 2015 at 14:21 GMT

---

Note that the bonuses to Dia, Bio, Blind, Slow, Paralyze, Silence, Gravity, Stun ONLY occur if the spell/enfeeble is landed on the monster 2~3 seconds after the shot; kind of like a magic burst. This wasn't stated in the opening post, so adding it here.

[topaz-bot]

Comment by teschnei
Wednesday May 27, 2015 at 14:41 GMT

---

er... no, that is not true at all. it enhances it as long as the debuff is applied to the target when the quick draw is fired

[topaz-bot]

Comment by dazusu
Wednesday May 27, 2015 at 15:15 GMT

---

Maybe I'm remembering wrong; I thought the debuff was only amplified if the quickdraw shot landed a few seconds after the debuff was applied - but if it was too long after, the bonus didn't happen (I got the order the wrong way around in my other post).

I could easily be mistaken, it was a long time ago I did shit on retail that required a COR :)

[topaz-bot]

Comment by RwNigma
Wednesday Jun 03, 2015 at 18:59 GMT

---

Eh. No one needs a COR, but I really enjoy the job and was just making sure quick draw was working correctly. Can we confirm or deny the few seconds window because a lot of skill chains and magic bursts aren't working as intended.

[topaz-bot]

Comment by teschnei
Wednesday Jun 03, 2015 at 19:03 GMT

---

The few seconds window is denied. If you are having problems timing
weaponskills or magic bursts, please open a new issue on it.

[topaz-bot]

Comment by RwNigma
Wednesday Jun 03, 2015 at 19:08 GMT

---

Awesome. Thanks teschnei. I will check some skill chains and get back on that.