-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid HTML structure in search result item #1395
Comments
Ah, interesting. One of the accessibility checking tools I used (Axe DevTools) says this:
Either way, based on the documentation, yes, I think the second part of my initial description that says we shouldn't have a I guess I'm not completely clear on whether the first part -- whether the Regardless, this doesn't seem to have a negative effect on the UI, and the other accessibility tools I used didn't mention this issue, so perhaps I should close this ticket? |
🤔 . It sounds like a |
Needs developer investigation but can be worked on. |
Fix PR for: #1468 |
Within the search result item structure there is this code for displaying the breadcrumb links/path to the item:
This raises an accessibility error, and is also just invalid HTML, I believe. The
dl
can only containdt
anddd
elements, so the childdiv
is invalid, as is the subsequentol
.Probably fixable just by changing the
dl
to adiv
? However, if the result item has metadata to display aside from the breadcrumb path (e.g., an abstract/scope value), that part is also within thedl
and includes an additional invaliddiv
:Basically it seems we're using a
dl
for the result item metadata following the basic Blacklight pattern (where thedl
is used correctly and appropriately for displaying several field labels and values), but ArcLight result items display very different item metadata, so thedl
ends up interspersed with a lot of invalid elements.Perhaps the whole result item structure in ArcLight should be rewritten (ignoring the Blacklight way of doing it) with an eye on valid HTML.
The code in question is what renders this:
The text was updated successfully, but these errors were encountered: