diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 652c36f53..01839f7d6 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -46,17 +46,9 @@ jobs: BOOTSTRAP_VERSION: ${{ matrix.bootstrap_version }} ENGINE_CART_RAILS_OPTIONS: "--skip-git --skip-listen --skip-spring --skip-keeps --skip-coffee --skip-test --css bootstrap ${{ matrix.additional_engine_cart_rails_options }}" steps: + - name: Install ImageMagick + run: sudo apt install imagemagick - uses: actions/checkout@v4 - # Remove these Chrome steps after https://issues.chromium.org/issues/351858989 is fixed - - name: Setup a specific version of Chrome - uses: browser-actions/setup-chrome@v1 - id: setup-chrome - with: - chrome-version: 126 - install-chromedriver: true - install-dependencies: true - - name: Set CHROME_BIN environment variable - run: echo "CHROME_BIN=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV - name: Set up Ruby ${{ matrix.ruby }} uses: ruby/setup-ruby@v1 with: diff --git a/spec/controllers/spotlight/bulk_updates_controller_spec.rb b/spec/controllers/spotlight/bulk_updates_controller_spec.rb index 7d4deb9b3..4f60cc31f 100644 --- a/spec/controllers/spotlight/bulk_updates_controller_spec.rb +++ b/spec/controllers/spotlight/bulk_updates_controller_spec.rb @@ -47,7 +47,7 @@ } content = CSV.parse(response.body) - expect(content.length).to eq 56 + expect(content.length).to eq(56) expect(content[0]).to eq ['Item ID', 'Item Title', 'Visibility'] end end diff --git a/spec/features/autocomplete_typeahead_spec.rb b/spec/features/autocomplete_typeahead_spec.rb index 3e23b27f3..3c090c418 100644 --- a/spec/features/autocomplete_typeahead_spec.rb +++ b/spec/features/autocomplete_typeahead_spec.rb @@ -21,7 +21,7 @@ expect(page).to have_css('.leaflet-container', visible: true) click_button 'Save changes' - sleep 1 # Test fails without this after move to Propshaft. + sleep 2 # Test fails without this after move to Propshaft. featured_image = Spotlight::FeaturedImage.last @@ -40,7 +40,7 @@ check 'Show background image in masthead' fill_in_typeahead_field(with: 'xd327cm9378', type: 'featured-image') - sleep 1 # HACK: that seems to mysteriously work. + sleep 2 # HACK: that seems to mysteriously work. expect(page).to have_css('[data-panel-image-pagination]', text: /Image 1 of 2/, visible: true) diff --git a/spec/features/javascript/edit_in_place_spec.rb b/spec/features/javascript/edit_in_place_spec.rb index a71e32496..a42e4d831 100644 --- a/spec/features/javascript/edit_in_place_spec.rb +++ b/spec/features/javascript/edit_in_place_spec.rb @@ -90,7 +90,7 @@ end end - it 'updates the metadata label' do + it 'updates the metadata label', default_max_wait_time: 10 do visit spotlight.exhibit_dashboard_path(exhibit) within '#sidebar' do diff --git a/spec/features/javascript/feature_page_admin_spec.rb b/spec/features/javascript/feature_page_admin_spec.rb index 1a184a855..e33bc865c 100644 --- a/spec/features/javascript/feature_page_admin_spec.rb +++ b/spec/features/javascript/feature_page_admin_spec.rb @@ -55,6 +55,8 @@ end it 'stays in curation mode if a user has unsaved data' do + skip('Chromedriver automatically dismisses alerts so this test does not work') + visit spotlight.edit_exhibit_feature_page_path(page1.exhibit, page1) fill_in('Title', with: 'Some Fancy Title') @@ -66,6 +68,8 @@ end it 'stays in curation mode if a user has unsaved contenteditable data' do + skip('Chromedriver automatically dismisses alerts so this test does not work') + visit spotlight.edit_exhibit_feature_page_path(page1.exhibit, page1) add_widget 'solr_documents'