Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse categories not updating #2968

Closed
jcoyne opened this issue Mar 10, 2023 · 5 comments · May be fixed by #2970
Closed

Browse categories not updating #2968

jcoyne opened this issue Mar 10, 2023 · 5 comments · May be fixed by #2970
Assignees
@jcoyne @taylor-steve

Comments

@jcoyne
Copy link
Member

jcoyne commented Mar 10, 2023

I’m getting some unexpected behavior using exhibit tags to make browse categories and want to check to see if this is a bug or if its how browse categories are supposed to work.

I tagged 55 items with the “qalaat-seman” tag
then built a browse category from all records with the “qalaat-seman” tag
then I tagged more records with the “qalaat-seman” tag

I was expecting the browse category to include these new records but it doesn’t. I then manually selected the linked tag from one of the records which led back to a search result of all records with that tag. I tried to "update the existing category" from those results but the category was not updated.

This seems to resolve after clearing the rails cache, so there seems to be some place where we aren't poisoning the cache.

Moved from sul-dlss/dlme#1753
@jcoyne jcoyne mentioned this issue Mar 10, 2023
Open
@taylor-steve taylor-steve self-assigned this Sep 10, 2024
@taylor-steve
Copy link
Contributor

I cannot seem to recreate this, perhaps this has been fixed in the interim. It'd be appreciated if another dev could try and confirm/deny.

@hudajkhan
Copy link
Contributor

hudajkhan commented Sep 11, 2024 •
edited
Loading

@taylor-steve I tried this out and browse categories also worked for me correctly when I had made the categories public.
Steps:
I added the tag "qalaat-seman" to four items in the exhibit, did a search for that tag, saved the search, went to the curation admin interface and selected browse, added the search as a browse category. I looked at the page for that browse category independently and could see the items. I added the browse category widget to a page and could see the items (once that category was made public). I added the tag to two more items and could see those items in the various pages as well. Screenshots for the pages after adding two items are below:

On browse page
Screenshot 2024-09-10 at 6 08 59 PM

On widget in page, shows 6 items (after starting with 4 and then adding 2)
Screenshot 2024-09-10 at 6 07 40 PM

@corylown
Copy link
Contributor

I also cannot duplicate this problem. If I add a tag to an item they show up right away in the browse category built from that tag.

@cbeer
Copy link
Member

cbeer commented Sep 11, 2024 •
edited
Loading

Is it possibly related to bulk tagging?

Reindex busts the exhibits cache with: https://github.com/projectblacklight/spotlight/blob/main/app/jobs/spotlight/reindex_job.rb#L20

But I don't see anything similar in AddTagsJob:
https://github.com/projectblacklight/spotlight/blob/main/app/jobs/spotlight/add_tags_job.rb

(I mean, it's also possible acts-as-taggable does it under the hood now 🤷)

@taylor-steve
Copy link
Contributor

Bulk tagging is a good thought. I tried a few variations during my attempt to recreate without any luck. I'm inclined to close this for now and re-open if it reoccurs. Any objections, or do folks feel this is serious enough to dig through previous versions to replicate/isolate the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

@taylor-steve taylor-steve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Poision the exhibit cache value when a document is updated projectblacklight/spotlight
5 participants
@jcoyne @cbeer @corylown @hudajkhan @taylor-steve