Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to fetch ACLs for unsaved/new scopes #660

Open
derrabauke opened this issue May 3, 2023 · 0 comments
Open

Don't try to fetch ACLs for unsaved/new scopes #660

derrabauke opened this issue May 3, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@derrabauke
Copy link
Contributor

Description

In the scope.edit view when creating a new scope, the ACL table tries to fetch the ACLs for the current scope. As the scope model isNew, it can not have any ACLs and the request for the table returns a 400, cause it's missing the scope id query param. As we know this request will fail up front, we should not make it in the first place.

image

Expected behavior

The table should not try to fetch the ACLs when the currently selected scope isNew === true.

@derrabauke derrabauke added bug Something isn't working good first issue Good for newcomers labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant