ASoC: Intel: avs: Check ida before free module

Checking if the module ida is empty before releasing the module is needed. A direct free ida may cause a kernel null pointer exception when the DSP rebooting failed. Signed-off-by: Wan, Xinxin <[email protected]>
projectceladon · Jun 18, 2024 · a2e0e29 · a2e0e29
1 parent 0b54d1d
commit a2e0e29
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/sound/soc/intel/avs/utils.c b/sound/soc/intel/avs/utils.c
@@ -222,7 +222,8 @@ void avs_module_id_free(struct avs_dev *adev, u16 module_id, u8 instance_id)
 		goto exit;
 	}
 
-	ida_free(adev->mod_idas[idx], instance_id);
+	if (!ida_is_empty(adev->mod_idas[idx]))
+		ida_free(adev->mod_idas[idx], instance_id);
 exit:
 	mutex_unlock(&adev->modres_mutex);
 }