Is is possible to "disable_on_etag_header: true" to envoy compressor extension

[boatmisser]

Can I pass disable_on_etag_header: true to envoy; preferably by HTTPProxy route; but envoy as whole would be acceptable.
Searched docs from both contour and envoy and haven't had much luck.
Thanks

Environment:

• Contour version: v1.18.3
• Kubernetes version: (use kubectl version): v1.21.14-eks-18ef993

[sunjayBhatia]

could you add a little more detail to the description on why this feature is useful to you? just for context for anyone picking this up and to add some justification

seems reasonable as a feature to add

see here where we configure the compressor filter:

contour/internal/envoy/v3/listener.go

Lines 251 to 277 in 491e263

	&http.HttpFilter{
	Name: "compressor",
	ConfigType: &http.HttpFilter_TypedConfig{
	TypedConfig: protobuf.MustMarshalAny(&envoy_compressor_v3.Compressor{
	CompressorLibrary: &envoy_core_v3.TypedExtensionConfig{
	Name: "gzip",
	TypedConfig: protobuf.MustMarshalAny(
	&envoy_gzip_v3.Gzip{},
	),
	},
	ResponseDirectionConfig: &envoy_compressor_v3.Compressor_ResponseDirectionConfig{
	CommonConfig: &envoy_compressor_v3.Compressor_CommonDirectionConfig{
	ContentType: []string{
	// Default content-types https://github.com/envoyproxy/envoy/blob/e74999dbdb12aa4d6b7a5d62d51731ea86bf72be/source/extensions/filters/http/compressor/compressor_filter.cc#L35-L38
	"text/html", "text/plain", "text/css", "application/javascript", "application/x-javascript",
	"text/javascript", "text/x-javascript", "text/ecmascript", "text/js", "text/jscript",
	"text/x-js", "application/ecmascript", "application/x-json", "application/xml",
	"application/json", "image/svg+xml", "text/xml", "application/xhtml+xml",
	// Additional content-types for grpc-web https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md#protocol-differences-vs-grpc-over-http2
	"application/grpc-web", "application/grpc-web+proto", "application/grpc-web+json", "application/grpc-web+thrift",
	"application/grpc-web-text", "application/grpc-web-text+proto", "application/grpc-web-text+thrift",
	},
	},
	},
	}),
	},
	},

we will likely have to add this feature as a global configuration, since the compressor filter is per Envoy HTTPConnectionManager and for HTTP virtualhosts there is only one (though there are many filter chains for HTTPS virtualhosts)

the global flag will probably go somewhere here:

contour/apis/projectcontour/v1alpha1/contourconfig.go

Line 324 in 491e263

type EnvoyListenerConfig struct {

(and accompanying config file location since that hasnt been deprecated yet)

let us know if you are willing to contribute, PRs are welcome! otherwise we will get this in the backlog and prioritized

[boatmisser]

thanks for the reply
we have a couple of issues; the first is Etag being stripped when envoy compresses the response.
The other is that we have a WAF outside of our cluster that performs some security checking on the response; this means that the WAF has to de-compress, process, then re-compress.
So this first issue could be worked around with using disable_on_etag_header: true; and this is the one we are concerned about.
However if we can't pass config to envoy; is it possible to disable envoy compression entirely?

[sunjayBhatia]

you can disable compression if your response content-type is not in this set:

contour/internal/envoy/v3/listener.go

Lines 272 to 281 in 602a77f

	ContentType: []string{
	// Default content-types https://github.com/envoyproxy/envoy/blob/e74999dbdb12aa4d6b7a5d62d51731ea86bf72be/source/extensions/filters/http/compressor/compressor_filter.cc#L35-L38
	"text/html", "text/plain", "text/css", "application/javascript", "application/x-javascript",
	"text/javascript", "text/x-javascript", "text/ecmascript", "text/js", "text/jscript",
	"text/x-js", "application/ecmascript", "application/x-json", "application/xml",
	"application/json", "image/svg+xml", "text/xml", "application/xhtml+xml",
	// Additional content-types for grpc-web https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md#protocol-differences-vs-grpc-over-http2
	"application/grpc-web", "application/grpc-web+proto", "application/grpc-web+json", "application/grpc-web+thrift",
	"application/grpc-web-text", "application/grpc-web-text+proto", "application/grpc-web-text+thrift",
	},

see envoy field documentation: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/compressor/v3/compressor.proto#envoy-v3-api-field-extensions-filters-http-compressor-v3-compressor-content-type

[tsaarni]

xref #6511