Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use 307/308 for HTTPRequestRedirectPolicy StatusCode #6788

Open
billyjs opened this issue Nov 26, 2024 · 1 comment · May be fixed by #6789
Open

Cannot use 307/308 for HTTPRequestRedirectPolicy StatusCode #6788

billyjs opened this issue Nov 26, 2024 · 1 comment · May be fixed by #6789
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@billyjs
Copy link

billyjs commented Nov 26, 2024

What steps did you take and what happened:
When using HTTPRequestRedirectPolicy in HTTPProxy you can only set the StatusCode to 301 or 302 but cannot use 307 or 308 for preserving the HTTP method.

What did you expect to happen:
307 and 308 values are allowed.

Environment:

  • Contour version: 1.30
@billyjs billyjs added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Nov 26, 2024
@github-actions GitHub Actions
Copy link

Hey @billyjs! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@billyjs billyjs linked a pull request Nov 26, 2024 that will close this issue
Open
billyjs added a commit to billyjs/contour that referenced this issue Nov 26, 2024
@billyjs
Update HTTPRequestRedirectPolicy StatusCode
4af6a40 
Use RedirectResponseCode instead of just 301/302 for HTTPRequestRedirectPolicy StatusCode

Fixes projectcontour#6788

Signed-off-by: Billy Schulze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update HTTPRequestRedirectPolicy StatusCode to use RedirectResponseCode billyjs/contour
1 participant
@billyjs