Skip to content

Ability to specify custom error page #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task
sgringwe opened this issue Apr 16, 2018 · 12 comments · May be fixed by #6974
Open
1 task

Ability to specify custom error page #320

sgringwe opened this issue Apr 16, 2018 · 12 comments · May be fixed by #6974
Labels
blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.33.0

Comments

@sgringwe
Copy link

sgringwe commented Apr 16, 2018 •
edited by davecheney
Loading

It'd be nice to have a way to show a custom error message if an error happens at the contour level, such as no healthy upstream servers.

If there is already a way to do this, it'd be nice to document it.

Blocked:
@davecheney davecheney added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 17, 2018
@davecheney
Copy link
Contributor

This sounds like a good thing to have if someone wants to investigate the options inside Envoy for doing this.

@dobozysaurus
Copy link

Looks like Envoy will support custom error responses in 1.9.0: envoyproxy/envoy#1178.

@davecheney davecheney removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 13, 2019
@davecheney davecheney added the blocked Blocked waiting on a dependency label Jun 18, 2019
@davecheney davecheney added this to the 0.15.0 milestone Jun 18, 2019
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. labels Jun 18, 2019
@davecheney
Copy link
Contributor

This is something i’d like to see fo contour 1.0. Marking as 0.15 to review if the feature has landed upstream.

@davecheney davecheney mentioned this issue Jun 18, 2019
Closed
@stevesloka
Copy link
Member

This feature right now is scheduled for Envoy v1.12.0.

@davecheney
Copy link
Contributor

Thanks for checking. I'm moving this to the unplanned milestone. It's unlikely that we'll make it to envoy 1.12 by october for contour 1.0 so we'll reassess after contour 1.0 ships.

@davecheney davecheney removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 18, 2019
@davecheney davecheney modified the milestones: 0.15.0, Unplanned Jul 18, 2019
@jpeach
Copy link
Contributor

jpeach commented Jun 10, 2020

xref #2515 which is closely related

@moderation moderation mentioned this issue Jul 28, 2020
Closed
@anupriya17
Copy link

This will help i think envoyproxy/envoy#11007

@jpeach jpeach added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 9, 2020
@jpeach
Copy link
Contributor

jpeach commented Aug 9, 2020

Yup, that looks promising.

xref #1898

@youngnick youngnick removed the blocked Blocked waiting on a dependency label Sep 15, 2020
@OrlinVasilev
Copy link
Member

@jpeach @stevesloka @sgringwe I think we can close this one right ?

@stevesloka
Copy link
Member

stevesloka commented Apr 12, 2022 •
edited
Loading

@OrlinVasilev nope, you'd need a way to configure this in Contour now. =) It's great envoy has support now, so please leave open to add the Contour support.

@OrlinVasilev
Copy link
Member

OrlinVasilev commented Apr 12, 2022 •
edited
Loading

Great thanks!! @stevesloka

@tsaarni tsaarni mentioned this issue Apr 12, 2022
Closed
@skriss skriss removed this from the Backlog milestone Jul 25, 2022
sunjayBhatia pushed a commit that referenced this issue Jan 30, 2023
@danehans
Updates e2e for non-kind clusters (#320)
70bdf09 
Signed-off-by: Daneyon Hansen <[email protected]>
@skriss skriss mentioned this issue Mar 21, 2023
Closed
@oliverkane
Copy link

Hi, just chiming in from what I think was creating a duplicate Issue. Essentially I'm looking for a way to handle a few cases:

  • When upstreams are unhealthy, rather than a static 503, I would like to customize the content. This is similar to how some cloud service providers handle things on eg "AWS Application Load Balancers".
  • When a wildcard parent route is specified, but the child router is not yet, or invalid, it would be nice to beable to "fall back" to a default handler.

In my days where I'd use the more common NGINX based ingresses, they used a feature called the default backend to accomplish some of these features.

@arkodg arkodg mentioned this issue May 5, 2023
Closed
usiegj00 added a commit to usiegj00/contour that referenced this issue Mar 27, 2025
@usiegj00
Add support for Envoy CustomResponse LocalReply in HTTPProxy CRDs
558b118 
This change enables Contour HTTPProxy CRDs to support matching internal response codes and replacing them with custom user-provided responses. This is particularly useful for cases where pods selected by a service are not-ready, allowing custom pages to be shown instead of the default 503 Unhealthy Upstream response.

Fixes projectcontour#320

Signed-off-by: Jonathan Siegel <[email protected]>
@usiegj00 usiegj00 linked a pull request Mar 27, 2025 that will close this issue
Open
@sunjayBhatia sunjayBhatia modified the milestones: 1.32.0, 1.33.0 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: No status
Milestone
1.33.0
Development

Successfully merging a pull request may close this issue.

Add support for Envoy CustomResponse LocalReply in HTTPProxy CRDs usiegj00/contour