Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent health checking on dead container #26

Open
jschwinger233 opened this issue Feb 19, 2020 · 1 comment
Open

agent health checking on dead container #26

jschwinger233 opened this issue Feb 19, 2020 · 1 comment
Assignees
Labels

Comments

@jschwinger233
Copy link
Member

assume there is a container run in private network binding port 8001, as container dies, container ip address would be empty string, remaining health check TCP net location as something like :8001.

in the case that there's another container running on that node with host network, binding 8001 port as well, health check for the dead one will pass, and core will mark the dead container with status running=false and healthy=true.

@jschwinger233
Copy link
Member Author

oh, 都忘了还有这个 issue, 大概就是说检查一个一个死掉的容器时拼出来的 netloc 是 :8000 这种, 导致 agent 去 net.Dial 这个地址会去连到 localhost:8000, 如果恰好宿主机上有个基础服务绑定了这个端口, 那这个死容器的 healthy 会被设为 true.

@CMGS CMGS added the wontfix label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants