Fix again user after free problems #296
Conversation
Commit 84646cc incorrectly re-introduced those lines that were dropped in decd704. Fixes projecthamster#295
|
ping @elbenfreund ? |
|
I don't understand the consequences, but this fixes the issue with lockscreen on my Fedora 29. Without this patch every lock means restarting gnome and all apps running inside. With this patch it's been working well even after several lock&unlock cycles. |
|
@rhertzog, #299 has a similar change to this PR. The discussion there suggests that the explicit clean that both this PR and #299 remove are not needed with newer (3.30?) gnome-shell version, but might be needed on older gnome-shell versions. Or would you think this is untrue and these are never appropriate? |
|
@matthijskooijman I think this is mostly irrelevant. We should just have a tagged version that is known to work with a given GNOME release. We don't really need a single version that works in all GNOME versions. And master should track the latest GNOME release... |
|
Thanks for fixing this @rhertzog - I had been working without hamster for several months, and my workflow was in shatters. This fixes the issue. Your other branches look really exciting! I hope that current project maintainers @elbenfreund will consider to bring aboard more maintainers as critical fixes are getting lost and lots of people are affected. |
|
Tested this on Ubuntu 18.04 where gnome-shell used to crash all the time. It's now stable. Thanks again @rhertzog and thanks @elbenfreund for picking up on a great project, please let us know how we can help! |
applied fix from <projecthamster#296>
|
I'm a happy user of the 3.36 branch so we can close this, yes. |
Commit 84646cc incorrectly
re-introduced those lines that were dropped in
decd704.
Fixes #295