Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of extension on extensions.gnome.org #304

Open
matthijskooijman opened this issue Mar 18, 2019 · 16 comments
Open

Status of extension on extensions.gnome.org #304

matthijskooijman opened this issue Mar 18, 2019 · 16 comments
Assignees
Labels
Packaging/Meta Issues and Bugs not related to the code itself but its packaging. waiting for feedback Feedback is required before further work on this can be done.

Comments

@matthijskooijman
Copy link
Member

I'm a bit confused about the extension at extensions.gnome.org. In particular:

@elbenfreund, Are you still available to maintain this extension? Is there a need for others to step in?

@DirkHoffmann
Copy link
Member

DirkHoffmann commented Mar 6, 2020

Following @elbenfreund's request, here is my audit of the presently four extension providers in https://extensions.gnome.org (aka EGO).

  • elbenfreund repository
    • provides: 3.20, 3.18, 3.16, 3.14, 3.12, 3.10, 3.8, 3.6.1, 3.6, 3.4
  • sufiyan repository
    • provides: 3.20, 3.18, 3.16, 3.14, 3.12, 3.10
    • Author is likely to be @MuhammadSufiyan.
  • jasuarez repository
  • lukes repository
    • provides: 3.24, 3.22, 3.20, 3.18. 3.16, 3.14, 3.12, 3.10
    • Named his repo "my extension -- remove it". Should not take long to convince EOG managers to execute his obvious wish.

@DirkHoffmann DirkHoffmann removed their assignment Mar 6, 2020
@DirkHoffmann
Copy link
Member

DirkHoffmann commented Mar 6, 2020

@MuhammadSufiyan, @jasuarez, if you could answer to this request to clean up (better: remove) your repositories here, it would make this task easier (and more transparent).

@elbenfreund
Copy link
Contributor

Given that @elbenfreund is a dev here, I suppose that's the primary one?

Yes

Is the latest released version (0.10.0) perhaps not uploaded to extensions.gnome.org

It is, but it has not passed review so far. The "review" - interface was very confusing for me, which even at that time of activity made me realize what is going on far too late.

There are a few minor changes "suggested" by the reviewer, iiuc. I guess we close the review for 0.10.0 and focus on the release you guys are working on?

@mwilck
Copy link
Contributor

mwilck commented Mar 6, 2020

I guess we close the review for 0.10.0 and focus on the release you guys are working on?

Fine with me, but you may want to comment on the version numbering convention to use in the future (see #319).

@elbenfreund
Copy link
Contributor

Btw: Mail about the "please delete me" extension has been send. waiting for feedback.

@elbenfreund elbenfreund added Packaging/Meta Issues and Bugs not related to the code itself but its packaging. waiting for feedback Feedback is required before further work on this can be done. labels Mar 6, 2020
@elbenfreund
Copy link
Contributor

Yuri Konotopov of EGO just got back to me. He will try to get in touch with "lukes" himself in order to see whats what.

We worked together before on deprecated extensions, so I am confident that he will help us out if "lukes" can not be reached in a reasonable timeframe.

@jasuarez
Copy link

jasuarez commented Mar 6, 2020

@MuhammadSufiyan, @jasuarez, if you could answer to this request to clean up (better: remove) your repositories here, it would make this task easier (and more transparent).

Do you mean to remove our extension forks and keep only this one?

Besides the upgrades for 3.32 and 3.34, I have other features that I need for my own usage (though I think they can be interesting for others too); I made PR some time ago, but probably it should be updated; and I'm working on a new one that I need.

As soon as I finish, I can create a new PR; if it is finally imerged, then I will be more than happier to remove my extension.

@DirkHoffmann
Copy link
Member

DirkHoffmann commented Mar 6, 2020

Thanks for your answer, @jasuarez. Yes, we meant that it is too confusing for users to have several extensions with the same name in EGO.

Good to hear that you want to contribute. But I do not see your request in the PR list. Can you specify what you mean, please?

@elbenfreund
Copy link
Contributor

@jasuarez
Thank you for getting back to us so fast. :)

Do you mean to remove our extension forks and keep only this one?

We intend to avoid any confusion for regular users about what the "official" extension, supported by us, is. :)

I made PR some time ago, but probably it should be updated; and I'm working on a new one that I need.

Sounds interesting.

As soon as I finish, I can create a new PR; if it is finally imerged, then I will be more than happier to remove my extension.

While your extension description leaves no doubt about the fact that this is a personal fork, would you be open to consider renaming your extension title in a way that avoids confusion with official extension?

@jasuarez
Copy link

jasuarez commented Mar 6, 2020

Good to hear that you want to contribute. But I do not see your request in the [PR list]( is:pr author:@jasuarez ). Can you specify what you mean, please?

Because I just closed it :)

As I said, it has been there for a while, and I've been doing changes locally. So I think its better to provide a new MR, which I'll do as soon as I can

@jasuarez
Copy link

jasuarez commented Mar 6, 2020

While your extension description leaves no doubt about the fact that this is a personal fork, would you be open to consider renaming your extension title in a way that avoids confusion with official extension?

Sure! Renamed it to "Colored Hamster Tracker"

@DirkHoffmann
Copy link
Member

Because I just closed it :)

Right. My fault. I should have looked with the correct filter.

Eager to see your coloured hamster tracker.

@DirkHoffmann
Copy link
Member

Hi @elbenfreund,
There are questions on #321 about the status of this cleanup. There are still four extensions on EGO, one of them being @jasuarez's, which may stay there. But the most obvious to be removed is also still there. Do you think this will progress some time soon?
There was also a question how to contact EGO maintainers.
Can you help?

@DirkHoffmann
Copy link
Member

Yuri Konotopov of EGO just got back to me. He will try to get in touch with "lukes" himself in order to see whats what.

We worked together before on deprecated extensions, so I am confident that he will help us out if "lukes" can not be reached in a reasonable timeframe.

Three weeks are almost gone. Do you think it is worth retriggering the admin?

For the records, I contacted @MuhammadSufiyan by email tonight.

@DirkHoffmann
Copy link
Member

Can you help?

FTR, answer was given on #304.

@matthijskooijman
Copy link
Member Author

Any progress on this issue?

@DirkHoffmann, you said:

FTR, answer was given on #304.

But that links back to this issue. Did you intend to link elsewhere?

AFAICS, this issue mostly talks about clearing away other uploads of the extension to EGO, but the other part of this issue is uploading new version of the extension to the official repo (or whatever the terminology is) on EGO. AFAIU recent merges have made the extension in this repo usable with newer shell versions, so uploading a new version would make sense? AFAIU this can currently only be done by @elbenfreund? Is there a way this can be distributed to multiple people/accounts? If not, would it make sense to create a "hamster" account on EGO for the official version and upload there? The password could be shared among the maintainers here, or maybe (also) some automatic integration could be set up that autobuilds and uploads releases (AFAIU github can also store secrets and make them available to actions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Packaging/Meta Issues and Bugs not related to the code itself but its packaging. waiting for feedback Feedback is required before further work on this can be done.
Projects
None yet
Development

No branches or pull requests

5 participants