Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Replace calendar" option breaks, maybe simplify positioning options? #335

Open
matthijskooijman opened this issue Oct 19, 2020 · 1 comment

Comments

@matthijskooijman
Copy link
Member

When I select "Positioning: Replace calendar" in the extension settings, the extension is placed left of the calendar, but the calendar is also still shown. journalctl -g hamster shows:

okt 19 09:33:08 grubby gnome-shell[155596]: JS ERROR: ReferenceError: dateMenu is not defined
                                            _placeWidget@/home/matthijs/.local/share/gnome-shell/extensions/[email protected]/extension.js:228:13
                                            deferred_enable@/home/matthijs/.local/share/gnome-shell/extensions/[email protected]/extension.js:145:14
                                            enable/<@/home/matthijs/.local/share/gnome-shell/extensions/[email protected]/extension.js:131:14
                                            _makeProxyWrapper/</<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:262:21

Which explains this behavior. I'm not sure why this happens, looking at the source for my gnome-shell 3.36.3, I see that Main.panel.statusArea.dateMenu is still used, but maybe there is an ordering problem there?

Regardless, I was not actually using this positioning option, I just tried it when debugging another issue, so I don't care much about it. Given that this positioning option, and even more so the "Replace activities" option, messes with gnome-shell internals and produces fragile coupling with the gnome-shell internals, I wonder if the positioning options should maybe simplified to just "left", "center" and "right" (maybe also with an "insert-position" option to control the position within these three boxes)? I think there are other extensions available to remove the calendar or activities buttons, which should allow the same behavior for anyone that really needs this?

@mwilck
Copy link
Contributor

mwilck commented Jun 1, 2021

No solution to this problem, but we do have a new "center, next to calendar" placement option now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants