Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding activities in retrospect is very hard #627

Open
martijnbastiaan opened this issue Aug 6, 2020 · 4 comments · May be fixed by #630
Open

Adding activities in retrospect is very hard #627

martijnbastiaan opened this issue Aug 6, 2020 · 4 comments · May be fixed by #630
Labels
bug edit activity window

Comments

@martijnbastiaan
Copy link

Hi all,

It's currently very hard to add an activity after the fact. I've attached a video.

date_bugs_2-2020-08-06_22.06.10.mkv

I'm trying to accomplish:

  • Adding an activity on 29th of July 2020 (while ealier and newer activities exist)

Here's the steps I use and the issues I encounter (as can be seen in de video):

  • I click on an existing activity, and click the "+" to add an activity.
  • I try to change the start date to 29-07-2020
    • Issue 1: Notice that the end date is 2019!
  • I try to change the end date to 29-07-2020
    • Issue 2: Hamster doesn't let me change the end date
  • I fill in the start time.
    • Issue 3: While changing the time, the end date jumped to $currentday!
    • Issue 4: The end times are still calculated on the initial 22:06
  • I select an end date:
    • Issue 5: Hamster doesn't let me click "Save" because the dates in 'cmdline' do not correspond to the ones selected in the date widget.
@matthijskooijman
Copy link
Member

Thanks for the detailed report. We were aware the editing interface (which was only recently added) was not perfect yet and maybe released a bit to eagerly, but things seem considerably more broken than I thought.

  • Issue 2: I suspect you can only change the date after selecting a time, but that does not really make sense from a UX perspective.
  • Issue 3: I susect that if no date is selected yet and you enter a time, it defaults to the current date. It would probably be better if it would default to the start date (or maybe one day later when the time you enter is earlier than the start time, for intervals around midnight).
  • Issue 5: I belive the offset between cmdline and datepicker is previously reported as Offset between calendar selection and cmdline #590, see that issue for some additional analysis.

@ederag
Copy link
Collaborator

ederag commented Aug 10, 2020 •
edited
Loading

A fix for issue 5 was provided about 3 months ago: #590 (comment).
The rest is part of the "polish" mentioned in the release warning.
Still out; just passing by. Best wishes.

gsobczyk added a commit to gsobczyk/hamster that referenced this issue Aug 14, 2020
@gsobczyk
Update edit_activity.py to every component in form be aware of select…
8507c0a 
…ed date

For activity in cmdline: `some activity` (without date and time)
- checked incrementing and decrementing day
- checked date picker
- checked date picker set to one date and cmdline on another date (cmdline has higher priority)

This fixes projecthamster#627 Adding activities in retrospect is very hard.
gsobczyk added a commit to gsobczyk/hamster that referenced this issue Aug 14, 2020
@gsobczyk
Update edit_activity.py to every component in form be aware of select…
f48d1ae 
…ed date

For activity in cmdline: `some activity` (without date and time)
- checked incrementing and decrementing day
- checked date picker
- checked date picker set to one date and cmdline on another date (cmdline has higher priority)

This fixes projecthamster#627 Adding activities in retrospect is very hard.
@gsobczyk gsobczyk linked a pull request Aug 14, 2020 that will close this issue
Open
@ederag ederag mentioned this issue Mar 13, 2021
Open
@szebenyib szebenyib mentioned this issue Jun 1, 2021
Closed
@matthijskooijman matthijskooijman mentioned this issue Nov 20, 2023
Open
@ezeedub
Copy link

ezeedub commented Jan 15, 2024

@matthijskooijman

I've been combing through some of the date issues to see if this has been mentioned, and but haven't found it, so since you just mentioned this ticket in your release comments #748 as something you're still working on, I thought I'd ask here...

I would find it very useful to have the default date in the "activity add" screen match the date I have selected in the main app window. Eg, I often need to enter activity for the previous week, so I go back to the previous Monday, and click the +. It would be great if that dialog was on that date (prev Monday). However, it is on the current date, and I always have to repeat setting the date on the add screen.

@matthijskooijman
Copy link
Member

I would find it very useful to have the default date in the "activity add" screen match the date I have selected in the main app window. Eg, I often need to enter activity for the previous week, so I go back to the previous Monday, and click the +. It would be great if that dialog was on that date (prev Monday). However, it is on the current date, and I always have to repeat setting the date on the add screen.

I have exactly the same experience, so I would also like to see this! Should probably default to the start date of the range (in case you are viewing more than one day).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug edit activity window
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding activities in retrospect is very hard gsobczyk/hamster
4 participants
@matthijskooijman @ezeedub @martijnbastiaan @ederag