diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 98fd6bc74..7c638bc6c 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -30,8 +30,8 @@ jobs: test: runs-on: windows-2019 steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' @@ -53,8 +53,8 @@ jobs: promtool: runs-on: windows-2019 steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' @@ -92,8 +92,8 @@ jobs: git config --global core.autocrlf false git config --global core.eol lf - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' @@ -101,11 +101,4 @@ jobs: uses: golangci/golangci-lint-action@v6 with: version: v1.58 - args: "--timeout=5m --out-format github-actions,colored-line-number" - - # golangci-lint action doesn't always provide helpful output, so re-run without the action for - # better output of the problem. - # The cache from the golangci-lint step is re-used here, so this step should finish quickly. - - name: errors - if: ${{ failure() }} - run: golangci-lint run --timeout=5m -c .golangci.yaml + args: "--timeout=5m --out-format github-actions,colored-line-number" \ No newline at end of file diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index 4498bdb6e..a86b70a77 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -17,7 +17,7 @@ jobs: name: Check for spelling errors runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: codespell-project/actions-codespell@master with: check_filenames: true diff --git a/Makefile b/Makefile index d4b50c90e..dd1fa1d5e 100644 --- a/Makefile +++ b/Makefile @@ -65,20 +65,20 @@ build-all: $(addprefix sub-build-,$(ALL_OS)) push: set -x; \ - for osversion in ${ALL_OS}; do \ - $(DOCKER) tag local/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion} $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ - $(DOCKER) push $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ - $(DOCKER) manifest create --amend $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION) $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ - full_version=`$(DOCKER) manifest inspect $(BASE_IMAGE):$${osversion} | grep "os.version" | head -n 1 | awk -F\" '{print $$4}'` || true; \ - $(DOCKER) manifest annotate --os windows --arch amd64 --os-version $${full_version} $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION) $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ + for docker_repo in ${DOCKER_REPO}; do \ + for osversion in ${ALL_OS}; do \ + $(DOCKER) tag local/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion} $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ + $(DOCKER) push $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ + $(DOCKER) manifest create --amend $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION) $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ + full_version=`$(DOCKER) manifest inspect $(BASE_IMAGE):$${osversion} | grep "os.version" | head -n 1 | awk -F\" '{print $$4}'` || true; \ + $(DOCKER) manifest annotate --os windows --arch amd64 --os-version $${full_version} $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION) $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION)-$${osversion}; \ + done; \ + $(DOCKER) manifest push --purge $${docker_repo}/$(DOCKER_IMAGE_NAME):$(VERSION); \ done - $(DOCKER) manifest push --purge $(DOCKER_REPO)/$(DOCKER_IMAGE_NAME):$(VERSION); - -sub-push-%: - $(MAKE) DOCKER_REPO=$* push .PHONY: push-all -push-all: build-all $(addprefix sub-push-,$(ALL_DOCKER_REPOS)) +push-all: build-all + $(MAKE) DOCKER_REPO="$(ALL_DOCKER_REPOS)" push # Mandatory target for container description sync action .PHONY: docker-repo-name