Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertManagerConfig: Add support for the new msteamsv2_configs receiver #7051

Open
jonerer opened this issue Oct 29, 2024 · 7 comments
Open

Comments

@jonerer
Copy link

jonerer commented Oct 29, 2024

Component(s)

AlertManagerConfig

What is missing? Please describe.

I'm running the prometheus-operator v0.72.0, but the latest has the same issue. I have manually set the version of alertmanager to v0.28.0-rc.0 in the "Alertmanager" object. I did this because alertmanager has added support for a new receiver: prometheus/alertmanager#4024 which is highly anticipated. But when I try to use it by adding it to my config (following the steps outlaid in prometheus/alertmanager#3920 (comment) ), it doesn't actually get synced into the alertmanager Pod.

It gets blocked by the prometheus operator which doesn't recognize the field:

level=error ts=2024-10-29T09:50:34.557049663Z caller=klog.go:126 component=k8s_client_runtime func=ErrorDepth msg="sync "prometheus-s ││ tack/prometheus-stack-prometheu-alertmanager" failed: provision alertmanager configuration: failed to initialize from secret: yaml: u ││ nmarshal errors:\n line 27: field msteamsv2_configs not found in type config.plain"

The problem is that prometheus-operator tries to marshal it, and it doesn't exist in the object here:

type receiver struct {

But it does here:
https://github.com/prometheus/alertmanager/blob/ff8c09d60174f27850830ceed6be38b3cf86974b/config/config.go#L988

Thanks in advance

Describe alternatives you've considered.

No response

Environment Information.

Environment

Kubernetes Version: 1.29.8
Prometheus-Operator Version: v0.72.0
Alertmanager version: v0.28.0-rc.0

@jonerer jonerer added kind/feature needs-triage Issues that haven't been triaged yet labels Oct 29, 2024
@simonpasquier simonpasquier added help wanted and removed needs-triage Issues that haven't been triaged yet labels Oct 29, 2024
@sebagarayco
Copy link

+1 to this. I'm having the same issue

@Zheer09
Copy link

Zheer09 commented Nov 4, 2024

+1

@slashpai
Copy link
Contributor

slashpai commented Nov 4, 2024

We would need to wait till 0.28 is released 🙂

@sebagarayco
Copy link

We would need to wait till 0.28 is released 🙂

Do you know if this is happening before end of December ?

@NicoGartmann
Copy link

NicoGartmann commented Dec 4, 2024

Hello, we are having the same issue. Is there any workaround until the 0.28 gets released?
E.g adding the msteamsv2_configs via a configmap or secret to the receiver struct?

MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 17, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 21, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
@RuStyC0der
Copy link

Hi there, just got updated alertmanager to 0.28.0 but issue still persists. I use prometheus stack chart version 68.3.0 with alertmanager v0.28.0 and prometheus operator v0.79.2 and can confirm issue exists. I can see reconciliation error like this
field msteamsv2_configs not found in type config.plain

However if I will exec into pod, change config directly and then reload alertmanager manually with kill -HUP 1 it will load and validate new conf.

Can someone validate it works on their side or it still an issue. Thanks)

@shawmarsh
Copy link

I have the same issue with v68.3.0 kube prometheus stack chart. I also tried installing the alertmanager v0.28.0 chart by itself and encountered the same issue.

MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 28, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 29, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
MariusSchiffer added a commit to MariusSchiffer/prometheus-operator that referenced this issue Jan 29, 2025
This was added in alertmanager v0.28.0.

Fixes prometheus-operator#7051

Signed-off-by: Marius Schiffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants