Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one endpoint /metrics to expose all metrics (without /pve) for PushProx tool. #186

Open
witold-gren opened this issue Oct 21, 2023 · 1 comment

Comments

@witold-gren
Copy link

Hey,

I implemented prometheus-pve-exporter in my proxmox server. But my entire monitoring is run in external cloud configuration. To provide one endpoint to scrape all metrics from all services run in proxmox in decided to use PushProx. The all configuration works quite well.. but I realised that when I use this https://github.com/prometheus-community/PushProx then I can not scrape metrics from endpoint /pve, only endpoint /metrics ara available.

Is it possible to expose all metrics on one /metrics endpoint? Maybe create extra flags to change this behavior without breaking the current configuration?

@znerol
Copy link
Member

znerol commented Nov 5, 2023

Thanks for the suggestion and sorry for the late response. Many exporters provide a --web.telemetry-path flag which can be used to modify the /metrics endpoint. E.g. node_exporter.go. That wouldn't be too hard to implement.

However, also note that from an operational point of view pve_exporter is much closer related to snmp_exporter. And that exposes separate paths as well: metrics_path for metrics endpoint for SNMP exporter itself and prober_path (Endpoint to do SNMP scrapes). Interestingly there is no flag to customize the latter. Hence, it might be worth to investigate how PushProx is supposed to proxy requests to snmp exporter (since people might be more familiar with that one).

Linking related issue over in prometheus-community/PushProx#159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants