Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for basic_auth_users and tls_server_config in pve_exporter #298

Closed
kbaniszack opened this issue Nov 16, 2024 · 3 comments
Closed

Comments

@kbaniszack
Copy link

Hello,

I have a couple of questions regarding the pve_exporter:

Does pve_exporter support the basic_auth_users configuration like other Prometheus exporters? I couldn't find any documentation or mention of it, and it seems unavailable in the current version.
Is tls_server_config fully supported? I tried configuring it, but it didn't seem to have any effect.

Context:
From my understanding, many Prometheus exporters implement these features via the Exporter Toolkit. Does pve_exporter rely on this toolkit, or is there another reason these features might not work as expected?

Thanks in advance

@znerol
Copy link
Member

znerol commented Nov 16, 2024

pve_exporter is written in python. Thus, it cannot reuse the Exporter Toolkit which is written in go. Authentication needs to be implemented in a reverse proxy at this time.

@znerol znerol closed this as completed Nov 16, 2024
@kbaniszack
Copy link
Author

Thank you.
Do you think it's possible to implement basic_auth_users in the module directly instead of having to do it in a reverse proxy?
I might eventually look into doing the implementation if it is possible and interesting.

@znerol
Copy link
Member

znerol commented Nov 18, 2024

Honestly I don't know. If gunicorn supports basic auth, then it might be possible.

As per #293: Maybe there is a way to refactor the code such that pve exporter can be run as a wsgi app. That would make it easier to swap out the wsgi server when needed (or adapt its configuration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants