Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to return str instead bytes from generate_latest() #1060

Open
stalkerg opened this issue Oct 9, 2024 · 2 comments
Open

Allow to return str instead bytes from generate_latest() #1060

stalkerg opened this issue Oct 9, 2024 · 2 comments

Comments

@stalkerg
Copy link

stalkerg commented Oct 9, 2024

Because converting to bytes anyway happened at the end of function, have sense to return str instead bytes or have options to avoid extra transformation. (many API expected str)

@csmarchbanks
Copy link
Member

I think the ship has sailed on this, any uses of generate_latest today will be using bytes and changing the return type would be a significant breaking change.

@stalkerg
Copy link
Author

I think we can create a new function generate_latest_b() and return bytes, and original function will just call new function and convert to string.
Seems like the current behavior comes from Python2 era.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants