Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop #132

Open
lawrencejones opened this issue Jun 16, 2019 · 3 comments
Open

Rubocop #132

lawrencejones opened this issue Jun 16, 2019 · 3 comments

Comments

@lawrencejones
Copy link
Contributor

lawrencejones commented Jun 16, 2019 •
edited
Loading

It's often a good idea in open-source projects to provide automated code linting. Rubocop is a great gem that does this for Ruby and is highly customisable.

Is there any reason we wouldn't add this to make it easier for people to create code-style consistent PRs?
@dmagliola
Copy link
Collaborator

So, historically... This

I agree it'd be a good idea to try to re-add it, though.

@lawrencejones
Copy link
Contributor Author

That's fine, I can understand that. These style guidelines do change with time- for several reasons, this can be quite sensible.

Happy to take the hit to reintroduce things as I think we get several significant benefits from it. Coupled with dependabot, I can't see this situation replacing itself (also, my best guess is this author wasn't aware of the autocorrect, which massively reduces the maintenance burden).

Will open a PR with rubocop changes.

@dmagliola
Copy link
Collaborator

Totally agreed, just thought I'd contribute how we got here

lawrencejones added a commit to lawrencejones/client_ruby that referenced this issue Jul 4, 2019
@lawrencejones
Add rubocop as development dependency
6f8721c 
Re-introduce rubocop as per issue prometheus#132 and pin to a specific style guide
used by GoCardless and open-sourced at gocardless/gc_ruboconfig. This
should reduce the frequency that style guidelines change between
versions.
lawrencejones added a commit to lawrencejones/client_ruby that referenced this issue Jul 17, 2019
@lawrencejones
Add rubocop as development dependency
ca4a231 
Re-introduce rubocop as per issue prometheus#132 and pin to a specific style guide
used by GoCardless and open-sourced at gocardless/gc_ruboconfig. This
should reduce the frequency that style guidelines change between
versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmagliola @lawrencejones