Replies: 5 comments 5 replies
-
cc @beorn7 Can you look at this? This seems histogram related. |
Beta Was this translation helpful? Give feedback.
-
That's certainly #440. The |
Beta Was this translation helpful? Give feedback.
-
I have tried to build a small program using the instrumentation library without the init functions in model/value_float.go and model/value_histogram.go. The binary size did not shrink. There must be another trick. |
Beta Was this translation helpful? Give feedback.
-
So here is my theory: After #440 , we started to use json-iterator for the first time at all in The API client in I see the following options:
Any thoughts? I'm not perfectly happy with either. I might hack up a pair of PRs for option (2) to see how bad it actually looks. |
Beta Was this translation helpful? Give feedback.
-
#453 and prometheus/client_golang#1225 should do the trick. |
Beta Was this translation helpful? Give feedback.
-
Hello,
in my application I use
client_golang
for instrumenting application code. If I updateprometheus/common
to v0.40 the increase in binary size is about 1 MB.I see that there are some new dependencies (json-iterator, modern-go/reflect2, moder-go/concurrent), I haven't looked at the code so I'm not sure if they are needed for my use case. Unless strictly required, can you please avoid including them unconditionally (e.g. by not instantiating these methods in
init
or by creating a separate module)? Thank youBeta Was this translation helpful? Give feedback.
All reactions