Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing #5

Open
gitcubehub opened this issue May 15, 2020 · 5 comments

Comments

@gitcubehub
Copy link

We are seeing below errors as result of Qualys Scan QID 11827

X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing on port 9100
X-XSS-Protection HTTP Header missing on port 9100
X-Content-Type-Options HTTP Header missing on port 9100

Is there a security patch or some config change in Node Exporter to add below security headers ?

X-XSS-Protection
X-Content-Type-Options
Content-Security-Policy
X-Frame-Options

@gitcubehub gitcubehub changed the title X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing @gouthamve -Please help-X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing May 15, 2020
@gitcubehub
Copy link
Author

Hi,
Can you please advice for fixing issue "HTTP Header missing on port Node Exporter 9100".

Thanks

@discordianfish
Copy link
Member

So I don't see why these headers would make anything more secure in the context of the node-exporter. Then again, I get where these best practices come from.
@SuperQ Thoughts? Maybe some set of defaults in prometheus' http lib would make sense..

@SuperQ
Copy link
Member

SuperQ commented Jun 22, 2020

Yes, this should probably move over to the new http front-end library in exporter-toolkit.

@SuperQ SuperQ transferred this issue from prometheus/node_exporter Jun 22, 2020
@roidelapluie roidelapluie changed the title @gouthamve -Please help-X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing X-Frame-Options or Content-Security:frame-ancestors HTTP Headers missing Jun 22, 2020
@topine
Copy link

topine commented Jul 16, 2020

Hello, I'm facing the same "issue".

In fact, security teams are always pointing this "vulnerability" because of PCI compliance.

Now that TLS is supported, we need to maintain a reverse proxy only for those security headers that is painful.

I agree that we would need a set of defaults ( or configurable headers) in the new front-end library.

I would like to contribute if needed/possible.

Thanks

@rsvas
Copy link

rsvas commented Dec 29, 2020

Following vulnerabilities about HTTP Security Headers Not Detected on on the node exporter endpoint port 9100 is creating issues, is there any plan for fixing this issue sooner? Really appreciate your response on this.

The same issue is also mentioned in security audit report: https://prometheus.io/assets/downloads/2020-07-21--cure53_security_audit_node_exporter.pdf
-> PRM-02-001 Web: General HTTP security headers missing (Medium)

  • X-Frame-Options : This HTTP response header improves the protection of web applications against clickjacking attacks. Clickjacking, also known as a "UI redress attack".
  • X-XSS-Protection : This HTTP header enables the browser built-in Cross-Site Scripting (XSS) filter to prevent cross-site scripting attacks
  • X-Content-Type-Options : This HTTP header prevents attacks based on MIME-type mismatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants