Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support underscores in metric name components #81

Open
matthiasr opened this issue Apr 8, 2019 · 2 comments
Open

Support underscores in metric name components #81

matthiasr opened this issue Apr 8, 2019 · 2 comments

Comments

@matthiasr
Copy link
Contributor

Break-out from #80:

The exporter's metric parsing currently fails if any component of the Graphite metric name contains underscores, unless there is a mapping that constructs a valid Prometheus name.

Even without a matching mapping, the exporter should handle these metric names and translate them to valid Prometheus metric names. Existing metric names for metrics without underscores should not change when doing this.

@glightfoot
Copy link
Contributor

glightfoot commented Jun 25, 2020

@xkilian can you provide the mapping config and some more example metrics that don't work? I threw together some tests on master and it appears to work fine

@xkilian
Copy link

xkilian commented Jun 25, 2020

The case here, is for a metric whose name is structured like: hostname_one.source.detail_modifier.type
If there is no matching mapping rule and it tries to do auto-mapping to a prometheus metric.
If the mapping config drops all unmatched metrics by default, then this does not apply. I will get something together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants