Add basic TLS listener support #611
Conversation
Signed-off-by: Tom Noonan II <[email protected]>
There was a problem hiding this comment.
Thank you for kicking this off!
per prometheus/exporter-toolkit#197 the TLS support is slated for removal
No, that issue is not about removal of the feature, only refactoring how it is implemented.
prometheus/exporter-toolkit was not used as the API of that project isn't clear from the documentation
This is true, but nonetheless we should not diverge from it in this project. It's not just about convenience of writing (and maintaining!) less code, it's also a common user interface across the Prometheus project, and it provides a common way to specify many parameters that do matter to many TLS users.
The Graphite exporter main() is a good starting point that illustrates how to set up the exporter-toolkit HTTP listener. The main steps are to let it add the flags, then start the listener. All the generic flags, including handling the details of which package implements the TLS configuration, are handled between these two.
|
Ack, that's a reasonable rejection. I'm going to close this and will reopen it later with requested changes. |
|
The level of refactor requested here is beyond what I can provide at this time. The statsd_exporter uses a mux, whereas graphite does not, and statsd has several endpoints which graphite does not: https://github.com/prometheus/statsd_exporter/blob/master/main.go#L513-L531 I will not be filing a followup PR at this time. |
This MR adds basic HTTPS listener support. This was implemented using dedicated config arguments, same as listenAddress, and Go's
http.ListenAndServeTLS(). prometheus/exporter-toolkit was not used as the API of that project isn't clear from the documentation and per prometheus/exporter-toolkit#197 the TLS support is slated for removal.Default options are HTTP so this does not change existing behavior or require any config changes by users.
Resolves #413