Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Load Generator to Query Pre-Generated Data Blocks #782

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions prombench/manifests/prombench/benchmark/6_loadgen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,23 @@ spec:
labels:
app: loadgen-querier
spec:
initContainers:
- name: download-key
image: docker.io/prominfra/prometheus-builder:master
imagePullPolicy: Always
command: [ "/go/src/github.com/key.sh" ]
env:
- name: PR_NUMBER
value: "{{ .PR_NUMBER }}"
- name: GITHUB_ORG
value: "{{ .GITHUB_ORG }}"
- name: GITHUB_REPO
value: "{{ .GITHUB_REPO }}"
- name: STORAGE
value: "/storage-paths"
volumeMounts:
- name: key
mountPath: /storage-paths
containers:
- name: prom-load-generator
image: docker.io/prominfra/load-generator:master
Expand All @@ -138,13 +155,17 @@ spec:
volumeMounts:
- name: config-volume
mountPath: /etc/loadgen
- name: key
mountPath: /config
ports:
- name: loadgen-port
containerPort: 8080
volumes:
- name: config-volume
configMap:
name: prometheus-loadgen
- name: key
emptyDir: {}
nodeSelector:
node-name: nodes-{{ .PR_NUMBER }}
isolation: none
Expand Down
97 changes: 86 additions & 11 deletions tools/load-generator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package main

import (
"flag"
"fmt"
"io"
"log"
Expand Down Expand Up @@ -92,6 +93,16 @@ type QueryGroup struct {
Step string `yaml:"step,omitempty"`
}

type BucketConfig struct {
Path string `yaml:"path"`
MinTime int64 `yaml:"minTime"`
MaxTime int64 `yaml:"maxTime"`
}

type bucketState struct {
bucketConfig *BucketConfig
}

func NewQuerier(groupID int, target, prNumber string, qg QueryGroup) *Querier {
qtype := qg.Type
if qtype == "" {
Expand Down Expand Up @@ -120,16 +131,63 @@ func NewQuerier(groupID int, target, prNumber string, qg QueryGroup) *Querier {
}
}

func (q *Querier) run(wg *sync.WaitGroup) {
// Function to load `minTime` and `maxTime` from bucket-config.yml
func loadBucketConfig() (*BucketConfig, error) {
filePath := flag.String("bucketconfig-file", "/config/bucket-config.yml", "Path to the bucket configuration file")
flag.Parse()

_, err := os.Stat(*filePath)
if os.IsNotExist(err) {
return nil, fmt.Errorf("file not found: %s", *filePath)
}

data, err := os.ReadFile(*filePath)
if err != nil {
return nil, fmt.Errorf("error reading file: %w", err)
}

var bucketConfig BucketConfig
err = yaml.Unmarshal(data, &bucketConfig)
if err != nil {
return nil, fmt.Errorf("error parsing YAML: %w", err)
}

return &bucketConfig, nil
}

func setconfig(v *BucketConfig, err error) *bucketState {
// If there is an error in reading bucket-config.yml file then just return nil.
if err != nil {
return nil
}
return &bucketState{
bucketConfig: v,
}
}

func (q *Querier) run(wg *sync.WaitGroup, timeBound *bucketState) {
defer wg.Done()
fmt.Printf("Running querier %s %s for %s\n", q.target, q.name, q.url)
time.Sleep(20 * time.Second)

for {
start := time.Now()

// If timeBound is not nil, both the "absolute" and "current" blocks will run;
// otherwise, only the "current" block will execute. This execution pattern is used
// because if Downloaded block data is present, both the head block and downloaded block
// need to be processed.
runBlockMode := "current"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea here is to alternate between current and absolute?
At least, put a comment saying that.

for _, query := range q.queries {
q.query(query.Expr)
if runBlockMode == "current" {
q.query(query.Expr, "current", nil)
} else if runBlockMode == "absolute" {
q.query(query.Expr, "absolute", timeBound)
}
if runBlockMode == "current" && timeBound != nil {
runBlockMode = "absolute"
} else if timeBound != nil {
runBlockMode = "current"
}
}

wait := q.interval - time.Since(start)
Expand All @@ -139,7 +197,7 @@ func (q *Querier) run(wg *sync.WaitGroup) {
}
}

func (q *Querier) query(expr string) {
func (q *Querier) query(expr string, timeMode string, timeBound *bucketState) {
queryCount.WithLabelValues(q.target, q.name, expr, q.qtype).Inc()
start := time.Now()

Expand All @@ -153,9 +211,19 @@ func (q *Querier) query(expr string) {
qParams := req.URL.Query()
qParams.Set("query", expr)
if q.qtype == "range" {
qParams.Set("start", fmt.Sprintf("%d", int64(time.Now().Add(-q.start).Unix())))
qParams.Set("end", fmt.Sprintf("%d", int64(time.Now().Add(-q.end).Unix())))
qParams.Set("step", q.step)
if timeMode == "current" {
qParams.Set("start", fmt.Sprintf("%d", int64(time.Now().Add(-q.start).Unix())))
qParams.Set("end", fmt.Sprintf("%d", int64(time.Now().Add(-q.end).Unix())))
qParams.Set("step", q.step)
} else {
endTime := time.Unix(0, timeBound.bucketConfig.MaxTime*int64(time.Millisecond))
qParams.Set("start", fmt.Sprintf("%d", int64(endTime.Add(-q.start).Unix())))
qParams.Set("end", fmt.Sprintf("%d", int64(endTime.Add(-q.end).Unix())))
qParams.Set("step", q.step)
}
} else if timeMode == "absolute" {
blockinstime := time.Unix(0, timeBound.bucketConfig.MaxTime*int64(time.Millisecond))
qParams.Set("time", fmt.Sprintf("%d", int64(blockinstime.Unix())))
}
req.URL.RawQuery = qParams.Encode()

Expand Down Expand Up @@ -203,9 +271,13 @@ func main() {
}
prNumber := os.Args[2]

configFile, err := os.ReadFile("/etc/loadgen/config.yaml")
configPath := flag.String("config-file", "/etc/loadgen/config.yaml", "Path to the configuration file")
flag.Parse()

configFile, err := os.ReadFile(*configPath)
if err != nil {
log.Fatalf("Failed to load config: %v", err)
fmt.Printf("Error reading config file: %v\n", err)
return
}

var config struct {
Expand All @@ -221,11 +293,14 @@ func main() {

var wg sync.WaitGroup

bucketConfig, err := loadBucketConfig()
timeBound := setconfig(bucketConfig, err)

for i, group := range config.Querier.Groups {
wg.Add(1)
go NewQuerier(i, "pr", prNumber, group).run(&wg)
go NewQuerier(i, "pr", prNumber, group).run(&wg, timeBound)
wg.Add(1)
go NewQuerier(i, "release", prNumber, group).run(&wg)
go NewQuerier(i, "release", prNumber, group).run(&wg, timeBound)
}

prometheus.MustRegister(queryDuration, queryCount, queryFailCount)
Expand Down