Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync #1271

Closed
ichub opened this issue Nov 27, 2023 · 3 comments
Closed

fix sync #1271

ichub opened this issue Nov 27, 2023 · 3 comments
Assignees
Labels

Comments

@ichub
Copy link
Contributor

ichub commented Nov 27, 2023

No description provided.

@ichub ichub added this to the Week of Nov 27 milestone Nov 27, 2023
@artwyman
Copy link
Member

Low-hanging fruit on my mind to tackle first here, based on Devconnect experience:

  • Add validation so a PCDCollection without identity never gets saved/uploaded/downloaded.
  • Save/load all user state as a single storage blob so different parts can’t get out of sync.
  • Stabilize the order of PCDs in storage, so that reissued tickets moving to the end of the list doesn’t cause extra uploads.
  • Detect conflicts (easy now) and perform a simple Union merge (not perfect, but doesn’t lose data).

@rrrliu rrrliu modified the milestones: Week of Nov 27, Week of Dec 4 Dec 4, 2023
@ichub ichub added the bug label Dec 5, 2023
@artwyman
Copy link
Member

artwyman commented Dec 7, 2023

The 3rd item above (stabilize order of PCDs in storage) is more complicated than I expected, so has been split out into #1340.

@artwyman
Copy link
Member

artwyman commented Dec 7, 2023

I've broken out the pieces of this effort, as well as related efforts into separate issues which you can see mentioned above. They have more detail and will allow us to prioritize the different work separately. I'll close out this issue.

Note that the bullet for "Save/load all user state as a single storage blob so different parts can’t get out of sync" didn't get its own issue, but is something I see as a refactoring which may be desirable to enable one of the other work items, primarily #1341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants