Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve PCD/subscription order in merge #1373

Open
artwyman opened this issue Dec 18, 2023 · 0 comments
Open

Preserve PCD/subscription order in merge #1373

artwyman opened this issue Dec 18, 2023 · 0 comments
Assignees

Comments

@artwyman
Copy link
Member

This is a follow-on to #1342.

The simple merge algorithm in #1342 merges both PCDs and subscriptions by starting with the remote copy (downloaded from server) and adding any missing objects (with unique IDs) from the local copy. The objects "added" are thus moved to the end of the default display order. This is user-visible, and may not always match expectations, though admittedly it's a pretty small flaw.

We could be more careful about preserving order, e.g. trying to insert a PCD in the "remote" collection at the same point in folder order where it appears in the "local" collection. A more robust form of merging such as CRDTs would also handle this case implicitly.

@artwyman artwyman self-assigned this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant