Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values on parameter prooph_event_store.projection_managers #54

Open
volkyeth opened this issue Dec 14, 2018 · 1 comment
Open

Comments

@volkyeth
Copy link

In this excerpt I believe the prooph_event_store.projection_managers was supposed to contain the projection managers names, but currently they're prepended with prooph_event_store:

foreach ($config['projection_managers'] as $projectionManagerName => $projectionManagerConfig) {
$projectionManagerId = "prooph_event_store.projection_manager.$projectionManagerName";
self::defineProjectionManager($container, $projectionManagerId, $projectionManagerConfig);
[$projectionManagerForProjectionsLocator, $projectionsLocator, $readModelsLocator] = self::collectProjectionsForLocators(
$projectionManagerConfig['projections'],
$projectionManagerId,
$projectionManagerForProjectionsLocator,
$projectionsLocator,
$readModelsLocator
);
$projectionManagers[$projectionManagerName] = "prooph_event_store.$projectionManagerName";
$projectionManagersLocator[$projectionManagerName] = new Reference($projectionManagerId);
}
$container->setParameter('prooph_event_store.projection_managers', $projectionManagers);

That parameter is only used on the ProjectionNamesCommand, so maybe it would make more sense to include only the names.

@codeliner
Copy link
Member

ping @UFOMelkor: any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants