-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use non-primary columns in crossref tables #1994
Conversation
@vol4onok thanks for coming back to this long lasting PR!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1994 +/- ##
=========================================
Coverage 89.28% 89.28%
Complexity 8058 8058
=========================================
Files 232 232
Lines 24534 24534
=========================================
Hits 21905 21905
Misses 2629 2629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi guys,
Not sure what was the reason for the change, but in Propel1 it was not mandatory to make the crossref table foreign keys also primary keys. It was handy when the crossref table relation had to be referenced further elsewhere.
I don't see any negative effects enabling this, but please correct me if I'm wrong.
Here is a pseudo-example:
#1559