Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit image analysis to specified channels doesn't seem to work with more than 2 channels #1

Open
OliverViking opened this issue Jul 27, 2020 · 3 comments
Assignees

Comments

@OliverViking
Copy link

I want to limit image analysis to three specific channels. See image below:

image

However, when I do that, the app seems to not work at all. It doesn't work in any of the three channels. If I however remove one item, like the two examples below:

image

image

Then the app works as expected.

I don't believe it is an issue with writing the name incorrectly, since as the two images with two specified channels work.

@col-panic
Copy link
Collaborator

@OliverViking could you please check if you see something in the app logs (see the docs on the mainpage on how to get the app logs)? Like Watching room or Room not found? What type of channels are those (private/broadcast/...)?

@OliverViking
Copy link
Author

Sorry for the delayed response @col-panic !

When I tested it again this time, I wasn't able to reproduce the issue. However it does not detect a test image 100% of the time, it seems that if a "spam" upload the image multiple times, the app lets some through. Could this actually be a rate limiting issue, and I was just unlucky when I tested the issue the other day?

In case the channel settings are still important even though I wasn't able to reproduce the issue again:

  • onboarding is a public collaborative channel
  • pre-screening is also a public collaborative channel. It is also the default channel people join when an account is created. The actual name for the channel is "--pre-screening--" but Rocket Chat weirdness treats it as "pre-screening".
  • photo-dna-testing is a private collaborative channel.

I did try creating a third public collaborative channel and adding it to the list of specified channels. It seems to work as expected.

@col-panic
Copy link
Collaborator

Thanks for the elaborated answer! To me this seems more like a "problem" with the PhotoDNA-API. Yes - they impose rate limiting as can be seen here https://developer.microsoftmoderator.com/docs/services/57c7426e2703740ec4c9f4c3/operations/57c7426f27037407c8cc69e6/

This operation accepts one image at a time with a maximum rate limit of 5 requests per second.

So in your case this limit may have been hit. In order to solve these "bursts" we would have to slow-down the transmission of images to the service. (This is not an easy patch and would also degrade the user-experienced performance)

As far as I can see this limit exists for the Match operation only (where the entire image is transmitted to the service for analysis) but not for the Match Edge Hash method of analysis (@prostasia knows about the difference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants