Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TEL #173

Closed
zy4 opened this issue Nov 27, 2017 · 3 comments
Closed

Refactor TEL #173

zy4 opened this issue Nov 27, 2017 · 3 comments

Comments

@zy4
Copy link
Member

zy4 commented Nov 27, 2017

There seems to be a lot which is going on but much is overhead and many things can also be deleted because they are unused.

The overall structure is more or less confusing and could be refactored by following a more conceptual and functional approach of how to wire dependencies and parameters together and of how to inject them into the right places.

zy4 added a commit that referenced this issue Nov 27, 2017
@zy4 zy4 self-assigned this Nov 27, 2017
@zy4 zy4 removed their assignment May 9, 2018
@felixgabler felixgabler self-assigned this Feb 5, 2019
@felixgabler
Copy link
Collaborator

We moved away from using the files under Tel/env in the toolkit itself. Only environment.sh still exists in order to be sourced by each node.
The most important variables are now included in the config.
This reduces complexity by a whole lot but still needs some more improving.

@felixgabler
Copy link
Collaborator

@zy4 what's the DoD for this issue?

@felixgabler felixgabler removed their assignment Jun 16, 2019
@zy4
Copy link
Member Author

zy4 commented Jun 20, 2019

closing in favor of #705 where most part of the work is to be done

@zy4 zy4 closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants