Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

automerge is getting blocked by review requirements #249

Closed
marten-seemann opened this issue Dec 11, 2021 · 2 comments
Closed

automerge is getting blocked by review requirements #249

marten-seemann opened this issue Dec 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@marten-seemann
Copy link
Contributor

image

I'm not sure if there's any way around this, but it would be really nice if we could somehow overwrite the review requirement for PRs opened by web3-bot. @galargh, any ideas?

@marten-seemann marten-seemann added the bug Something isn't working label Dec 11, 2021
@mvdan
Copy link
Contributor

mvdan commented Dec 11, 2021

I don't think there's a quick way around this; we could make the bot an administrator so it can skip the checks, but that seems like a can of worms.

As an alternative, the bot has write permissions, so I wonder if we could have a second bot approve the changes. Adds more steps and setup, but seems safer than giving a bot admin permissions or dropping the safety requirements entirely.

Another option, and what I would say is best, is to obey the repo's protections. If I've set up the repo to require approvals from maintainers, I would be surprised if our bots were engineered to ignore those. Even for CI changes which are presumably safe.

@galargh
Copy link
Contributor

galargh commented Aug 28, 2023

This issue was transferred to ipdxco/unified-github-workflows#37 in preparation for archiving of this repository.

@galargh galargh closed this as completed Aug 28, 2023
@github-project-automation github-project-automation bot moved this from 🥺 Backlog to 🥳 Done in InterPlanetary Developer Experience Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants