You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
I reviewed and approved ipld/go-codec-dagpb#37 to bump the semver bugfix version, and it worked when merged - the tag appeared etc. I just didn't notice that the git diff was adding one object key-value, rather than replacing the existing one.
I get that, semantically, it's the same - when decoding, the second key-value wins. Still, to avoid confusion, I think the versioning workflow should reject any version.json that isn't exactly an object with one version key.
The text was updated successfully, but these errors were encountered:
I reviewed and approved ipld/go-codec-dagpb#37 to bump the semver bugfix version, and it worked when merged - the tag appeared etc. I just didn't notice that the git diff was adding one object key-value, rather than replacing the existing one.
I get that, semantically, it's the same - when decoding, the second key-value wins. Still, to avoid confusion, I think the versioning workflow should reject any
version.json
that isn't exactly an object with oneversion
key.The text was updated successfully, but these errors were encountered: