-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #294
Comments
I'd like to ... I want to get the bundled Z3 updated, but that is still failing and I need to figure out the right fix. Just now in fixing something else, the WebAssembly build failed due to an error in Z3 and I've just submitted a PR for that. (That will require a new release of Z3...) Would be good to do though! |
Gotcha, thanks! Please let me know if there's any way I can help out; I've loved using this library and wouldn't mind contributing if there was something I could do. Out of curiousity, what is failing? I just pulled down Ohhhh, I see the failed Windows builds... |
Poking around at this a bit on my Windows 11 machine (apologies if you've already triaged all this):
It looks like for some reason the debug build is emitting a linker flag to link to
I'm guessing the default linker flags for the release profile link to |
I know that it is from doing debug builds on Windows, but not much beyond that. I haven't been booting my Windows machine often as of late ... I also know that it started when I increased the cmake version requirements in upstream Z3 (and therefore being subject to changes in the cmake policies). |
Ok, I just tracked down some Still looking through the changelog for that version, but the following item does pop out:
|
Not at all a CMake expert here, but I'm wondering if this is a This snippet seems to indicate that But CMP0091 seems to indicate that MSVC lib selection is no longer done through these flags. So maybe |
I've made #295 which contains a change that fixes debug builds on my machine. |
Looks like there's finally a new z3 release! |
Hey @waywardmonkeys, no rush, but is there any chance of a push to crates.io? Is there anything left blocking a release? |
hi @waywardmonkeys ! giving a gentle bump on this. waiting for the new version which contains a fix for #190. would be great if this is pushed soon assuming theres no blockage |
Yes, we should! There're a new PR that I'd like to get in and a couple of older ones that maybe should ... anyone have anything else they want to see get in this week? |
Nothing for me! |
I noticed it's been a while since a new version of these bindings have been pushed to crates.io and there's some really good stuff missing from that version.
Any possibility of a release in the near future?
The text was updated successfully, but these errors were encountered: