Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-85ztrjkqe_Make-the-metadata-extractor-lenient #169

Closed

Conversation

zubri
Copy link
Member

@zubri zubri commented Aug 23, 2023

No description provided.

@zubri
Copy link
Member Author

zubri commented Aug 23, 2023

@@ -168,7 +170,7 @@ public AbstractSwiftMessage() {}
@Deprecated
@ProwideDeprecated(phase3 = TargetYear.SRU2023)
protected AbstractSwiftMessage(final String content) {
this.message = content;
setMessage(content);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El mensaje original no hay que alterarlo. Aca en el entity hay que guardar el payload tal cual como se recibe. Estas clases son JPA entities.

El hack ese hay que hacerlo al momento de usarlo, cuando falla, que es puntualmente en el default metadata extractor.

PD : Ademas, no esta bueno que un setter modifique datos, en general se asume que los accesos (get set) son triviales. Incluso si tuviéramos Lombok en el proyecto, serian métodos generados.

}

private String makeXmlLenient(String xml) {
return xml.replaceFirst("(?i)<\\?XML", "<?xml");
Copy link
Member Author

@zubri zubri Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuando pongas el hack en el extractor, fíjate que el parametro no sea null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El hack de hecho va al proyecto ISO, no habria que tocar nada en Core

@ptorres-prowide ptorres-prowide deleted the CU-85ztrjkqe_Make-the-metadata-extractor-lenient branch August 23, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants