Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcards and/or regex in summon trigger phrases #58

Open
rainecheck opened this issue Mar 24, 2021 · 3 comments
Open

Wildcards and/or regex in summon trigger phrases #58

rainecheck opened this issue Mar 24, 2021 · 3 comments

Comments

@rainecheck
Copy link

Is your feature request related to a problem? Please describe.
Instead of a long list of very similar summon phrases, allowing for wildcards or regex in summon trigger phrases would be great - like 123* for "123 summon please" and 123 island 123 naxx etc. Or for regex, ^123.* etc.

Describe the solution you'd like
Allowance of wildcard or regex - preferably in the vein of what RaidSummon offers, although if you could provide proper escapes (e.g. their implementation of \s for whitespace doesn't work) that would be a plus ;)

Describe alternatives you've considered
The alternative is to rigorously beat guildies who are overly specific with locations ("123 naxxramas"), typo ("1233"), or add smilies after summons ("123 summons please :)") - bad for morale :(

@prowley
Copy link
Owner

prowley commented Apr 8, 2021

I actually specifically did not allow regex because half the world has no idea how to use it properly and the other half only think they do. I figured it would end up with a lot of phantom summon requests and nobody would be sure why (because anyone with the addon on could have something overly general)

@Runkel79
Copy link

Runkel79 commented Apr 8, 2021

@prowley I can absolutely see where you're coming from, but i don't think "phantom summons" are a real concern because:

A.) Raids are limited to 40 members
and
B.) The chance of raid members just "talking" about the Port Trigger Word is very low

Many players think it's kinda rude to only type "123" and add something to show their appreciation. Regex would imho a great addition. (maybe as a trigger disabled by default?)

@prowley
Copy link
Owner

prowley commented Apr 21, 2021

So, while I was thinking about this I saw bug reports in raidsummon that were right on point - people complaining about phantom requests they couldn't explain, regex, it's always regex. Not all raids are a close nit group of people who figure out the best thing for them, and that's one of the things I think about when considering one feature over another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants