Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Subnets not in same Vnet #55

Open
wants to merge 2 commits into
base: generation
Choose a base branch
from
Open

Fix for Subnets not in same Vnet #55

wants to merge 2 commits into from

Conversation

singhabh27
Copy link
Collaborator

@singhabh27 singhabh27 commented Aug 19, 2021 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

lshai06
lshai06 reviewed Aug 27, 2021
View reviewed changes
src/Migrate/custom/Start-AzMigrateTestMigration.ps1 Outdated
$Subnet = $Nic.IpConfigurations[0].Subnet.Id.Split("/")
$VnetID = "/$($Subnet[1])/$($Subnet[2])/$($Subnet[3])/$($Subnet[4])/$($Subnet[5])/$($Subnet[6])/$($Subnet[7])/$($Subnet[8])"
}
$TestNetworkID = $TestNetworkID.TrimEnd("/")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Should not be.

prsadhu-ms-idc
prsadhu-ms-idc reviewed Aug 30, 2021
View reviewed changes
src/Migrate/custom/Start-AzMigrateTestMigration.ps1
if ($VM)
{
$NicId = $VM.NetworkProfile.NetworkInterfaces[0].Id
$Nic = Get-Aznetworkinterface -resourceid $NicId -ErrorVariable notPresent -ErrorAction SilentlyContinue
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N,I capital.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsadhu-ms-idc prsadhu-ms-idc prsadhu-ms-idc left review comments

@lshai06 lshai06 lshai06 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singhabh27 @lshai06 @prsadhu-ms-idc