Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor App::update #747

Open
reflash opened this issue Oct 15, 2020 · 0 comments
Open

Refactor App::update #747

reflash opened this issue Oct 15, 2020 · 0 comments

Comments

@reflash
Copy link
Collaborator

reflash commented Oct 15, 2020

See ./src/Client/App.fs

let update msg model =
    match msg, model.CurrentPage with
    | NounDeclensionMsg msg, NounDeclension m ->
    ...
    | _, _ ->
        model, Cmd.none

This should be refactored as it can cause errors when some combinations are not handled. Current problem is that some combinations don't make sense e.g. NounDeclensionMsg, AdjectiveDeclension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant